Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app assembly #784

Merged
merged 4 commits into from
May 2, 2020
Merged

feat: app assembly #784

merged 4 commits into from
May 2, 2020

Conversation

jasonkuhrt
Copy link
Member

@jasonkuhrt jasonkuhrt commented May 2, 2020

Motivations:

  • decouple concept of starting server from assembly to support future serverless feature Serverless mode #782
  • assembly is the process of gathering the lazy state into a final runnable one
  • settings is now a component like schema and server
  • the components are designed to look a lot more symmetrical now
  • root app state is passed down to components which attach their namespaced state to, easier to reason about, think redux
  • introduce concept of checks that runs after schema assembly

BREAKING CHANGE:

  • server.start and server.stop are no longer exposed. If you had a use-case for them please open an issue to discuss.

TODO

  • docs
  • tests

@jasonkuhrt jasonkuhrt requested a review from Weakky May 2, 2020 03:09
jasonkuhrt added 3 commits May 1, 2020 23:18

Verified

This commit was signed with the committer’s verified signature.
codebytere Shelley Vohr

Verified

This commit was signed with the committer’s verified signature.
codebytere Shelley Vohr
@jasonkuhrt jasonkuhrt merged commit efc3ee3 into master May 2, 2020
@jasonkuhrt jasonkuhrt deleted the refactor/app-internal-architecture branch May 2, 2020 03:37
@jasonkuhrt jasonkuhrt mentioned this pull request May 5, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant