feat(build): treeshake build output #866
Merged
+759
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weakky
commented
May 15, 2020
| @@ -14,6 +14,7 @@ const BUILD_ARGS = { | |||
| '--stage': String, | |||
| '--entrypoint': String, | |||
| '-e': '--entrypoint', | |||
| '--no-bundle': Boolean, | |||
There was a problem hiding this comment.
Not sure how to call the new output. It's not really a bundle, but then, what it is?
This was referenced May 15, 2020
jasonkuhrt
approved these changes
May 18, 2020
|
Didn't get a chance to review this but at a high level we're already aligned after all our calls. Feel free to merge Monday! |
Weakky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #119
TODO