feat: Add new execution handler #921
Conversation
kristoferma
changed the title
There was a problem hiding this comment.
Thanks @kristoferma! The main thing I think we need to discuss is how to handle the lack of request data in the overall framework API. For example schema.addToContext calls currently expect it.
Because this is a non-trivial design problem, please open a new issue to discuss it and let's keep further discussion here light for now. Thanks!
-- edit
One crazy idea I'm having right now– is something like this:
- Statically analyze resolvers
- generate static data about which do and do not depend on the request object
- augment
schema.execto only see a sub-graph of the whole API, that part which does NOT depend on request object data.
I'll copy this over to the issue once you've created the issue @kristoferma
| operation | ||
| ) => { | ||
| const source = new Source(query) | ||
| const context = await contextCreator({}) |
There was a problem hiding this comment.
Hm, how is this going to work out?
AFAICT it requires that no resolvers in your app rely on data indirectly or directly from the request object.
If any do, there could be an error not caught until runtime.
This is the main design problem here to discuss I think.
| @@ -81,6 +82,48 @@ export const createRequestHandlerGraphQL: CreateHandler = (schema, createContext | |||
| return sendSuccess(res, result) | |||
| } | |||
|
|
|||
| export type ExecuteGraphQl = ( | |||
There was a problem hiding this comment.
Ideally this function is used within the createRequestHandlerGraphQL
src/runtime/server/server.ts
Outdated
| @@ -60,6 +61,13 @@ export function create(appState: AppState) { | |||
| }) ?? noop | |||
| ) | |||
| }, | |||
| get executeGraphQL() { | |||
There was a problem hiding this comment.
Executing a graphql query in its pure form seems like something that should be tied to the schema component, not the server component.
For example I could imagine this:
schema.exec(...)
jasonkuhrt
added
the
needs/discussion
|
Deploy request for graphql-nexus pending review. Review with commit b51b562 |
|
apollo-server-express reduced the amount of code needed to expose an execute handler from nexus. I am more than willing to put some effort in adding documentation to this feature if you can agree on my implementation. |
Adds feature mentioned by me in #782
I called the handler
executeGraphQL, but there is probably a better name for it.This enables me to execute GraphQL queries in Next.js GetServerSideProps without using a http server.
I only tested this with my project
TODO