Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change display name #862

Merged
merged 3 commits into from
Jul 6, 2023
Merged

feat: change display name #862

merged 3 commits into from
Jul 6, 2023

Conversation

leomotors
Copy link
Member

@leomotors leomotors commented Jul 6, 2023 •
edited
Loading

  • Add link to user dashboard (desktop only for now :trollface:)
  • Change display name (@MasterIceZ pls fix mobile if broken)
  • Change submissions to show display name instead of username

Recap

  • Username = Real name in Google / Username in GitHub
  • Name (displayName) = Real name in Google / Real name in GitHub
    Username === Name if use Google to sign up

@leomotors leomotors requested a review from a team July 6, 2023 14:32
@vercel
Copy link

vercel bot commented Jul 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
programming-in-th ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 2:40pm

@github-actions
Copy link

github-actions bot commented Jul 6, 2023 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 100% 15 / 15
🔵 Statements 100% 15 / 15
🔵 Functions 100% 1 / 1
🔵 Branches 100% 6 / 6
File CoverageNo changed files found.
Generated in workflow #17

@MasterIceZ
Copy link
Member

💀

@leomotors leomotors merged commit 23cfea5 into main Jul 6, 2023
@leomotors leomotors deleted the feat/display-name branch July 6, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leomotors @MasterIceZ