Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add page title metadata #946

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Conversation

gxjakkap
Copy link
Contributor

#945

I decided to mostly add title to pages visible to user. Let me know if I missed anything or did anything wrong.πŸ™‡πŸΌβ€β™‚οΈ

Static title:

  • /about
  • /archive/*
  • /assessments/*
  • /learn
  • /login
  • / (Home)
  • /submissions/*
  • /tasks

Dynamic title:

  • /tasks/:id

Copy link

vercel bot commented Feb 11, 2024

@gxjakkap is attempting to deploy a commit to the proginth Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Feb 11, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
programming-in-th βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 11, 2024 3:37pm

@MasterIceZ MasterIceZ enabled auto-merge (squash) February 12, 2024 08:16
@MasterIceZ MasterIceZ disabled auto-merge February 12, 2024 08:18
Copy link
Member

@leomotors leomotors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leomotors leomotors merged commit e257749 into programming-in-th:main Feb 17, 2024
3 checks passed
@leomotors leomotors linked an issue Feb 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta title missing on all pages.
3 participants