test: add plugin e2e tests #391
Conversation
Signed-off-by: Anubhav Gupta <[email protected]>
anubhav06
requested review from
jeremyrickard,
salaxander and
sozercan
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
==========================================
+ Coverage 32.51% 34.18% +1.67%
==========================================
Files 17 17
Lines 1621 1293 -328
==========================================
- Hits 527 442 -85
+ Misses 1062 819 -243
Partials 32 32 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Anubhav Gupta <[email protected]>
|
ready for review, is this fine? |
|
@anubhav06 sorry didn't get a chance to look at this yet. I will review after kubecon. |
There was a problem hiding this comment.
@anubhav06 sorry about the delay! added a few minor comments
.github/workflows/build.yml
Outdated
| @@ -128,3 +128,37 @@ jobs: | |||
| set -eu -o pipefail | |||
| . .github/workflows/scripts/buildkitenvs/${{ matrix.buildkit_mode}} | |||
| go test -v ./integration --addr="${COPA_BUILDKIT_ADDR}" --copa="$(pwd)/copa" -timeout 0 | |||
|
|
|||
| test-plugin: | |||
| needs: test-patch | |||
There was a problem hiding this comment.
why do we need to wait for test-patch? would needs: build work?
There was a problem hiding this comment.
yes, added
(I had thought the flow should be unit tests -> integration tests -> e2e tests, so we run e2e tests only if integration tests passes, not before)
|
I've my university exams going on so I'll fix this after 3-4 days. Thanks :) |
|
good luck on the exams! |
Signed-off-by: Anubhav Gupta <[email protected]>
Signed-off-by: Anubhav Gupta <[email protected]>
Signed-off-by: Anubhav Gupta <[email protected]>
Signed-off-by: Anubhav Gupta <[email protected]>
Signed-off-by: Anubhav Gupta <[email protected]>
Signed-off-by: Anubhav Gupta <[email protected]>
Signed-off-by: Anubhav Gupta <[email protected]>
Signed-off-by: Anubhav Gupta <[email protected]>
Signed-off-by: Anubhav Gupta <[email protected]>
Signed-off-by: Anubhav Gupta <[email protected]>
Signed-off-by: Anubhav Gupta <[email protected]>
Signed-off-by: Anubhav Gupta <[email protected]>
Signed-off-by: Anubhav Gupta <[email protected]>
Signed-off-by: Anubhav Gupta <[email protected]> Co-authored-by: Sertaç Özercan <[email protected]> Signed-off-by: Xander Grzywinski <[email protected]>
Add e2e tests for plugin
Closes #387