Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate patched image tag #492

Merged

Conversation

johnsonshi
Copy link
Contributor

Passing invalid patched image tag causes copa to freeze. This fix validates the patched image tag.

Closes #490

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (bbd8563) 32.59% compared to head (d3f76d0) 32.51%.

Files Patch % Lines
pkg/patch/patch.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
- Coverage   32.59%   32.51%   -0.09%     
==========================================
  Files          17       17              
  Lines        1617     1621       +4     
==========================================
  Hits          527      527              
- Misses       1058     1062       +4     
  Partials       32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Passing invalid patched image tag causes copa to freeze.
This fix validates the patched image tag.

Fixes project-copacetic#490.

Signed-off-by: Johnson Shi <[email protected]>
@johnsonshi johnsonshi force-pushed the johnsonshi/validate-patched-tag branch from d1342a0 to d3f76d0 Compare February 1, 2024 19:12
@johnsonshi johnsonshi requested a review from sozercan February 1, 2024 19:12
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@sozercan sozercan merged commit 1017994 into project-copacetic:main Feb 1, 2024
15 of 16 checks passed
@johnsonshi johnsonshi deleted the johnsonshi/validate-patched-tag branch February 1, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Invalid patched image tag causes copa to freeze
2 participants