-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: ignore CVE-2024-0567 and CVE-2023-5981 to fix ci #506
Conversation
Signed-off-by: Xander Grzywinski <[email protected]>
ae848a6
to
5f8b6ab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
+ Coverage 32.51% 34.18% +1.67%
==========================================
Files 17 17
Lines 1621 1293 -328
==========================================
- Hits 527 442 -85
+ Misses 1062 819 -243
Partials 32 32 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Xander Grzywinski <[email protected]>
@sozercan would we still expect the CI to be failing with this PR? |
@salaxander sounds like issues have not been addressed. you can test individually or add them back in |
This reverts commit 249eb8e. Signed-off-by: Sertac Ozercan <[email protected]>
4f38bb4
to
6e021a6
Compare
reverting last commit to unblock #508 |
Still seeing failures :(. The tests orginally failed before I had cleared those other 2 CVEs too |
Signed-off-by: Sertac Ozercan <[email protected]>
35dbe20
to
bf6a2b5
Compare
the trivy command and file looks correct in the test logs, https://github.com/ashnamehrotra/copacetic/actions/runs/7938093411/job/21676447774#step:9:101 but copa is still checking for the error https://github.com/ashnamehrotra/copacetic/actions/runs/7938093411/job/21676447774#step:9:1897. Maybe it could be something within trivy? |
608a9cb
to
01b930a
Compare
looks like |
@ashnamehrotra fyi - it was hard to test since it was just locking without your pr without giving the error, i merged them both in #509 to test |
Signed-off-by: Sertac Ozercan <[email protected]>
01b930a
to
3c7fa63
Compare
Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...
Closes #<issue_ID>