-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: increase code coverage #704
test: increase code coverage #704
Conversation
Signed-off-by: Miaha Cybersec <[email protected]>
Signed-off-by: Miaha Cybersec <[email protected]>
Signed-off-by: Miaha Cybersec <[email protected]>
Signed-off-by: Miaha Cybersec <[email protected]>
Signed-off-by: Miaha Cybersec <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #704 +/- ##
===========================================
+ Coverage 34.22% 47.46% +13.23%
===========================================
Files 18 18
Lines 1677 1677
===========================================
+ Hits 574 796 +222
+ Misses 1065 826 -239
- Partials 38 55 +17 ☔ View full report in Codecov by Sentry. |
The one failing test is due to mocks relying on copacetic/pkg/buildkit/buildkit.go Line 88 in 9da1246
|
@MiahaCybersec could you try running "go mod tidy"? |
Signed-off-by: Miaha Cybersec <[email protected]>
Signed-off-by: Miaha <[email protected]>
Had to resolve some conflicts between my branch and main which forced a merge |
This commit adds a new test case to verify the behavior when an invalid Docker address is provided. Ensures that the function correctly returns an error for malformed addresses. Signed-off-by: Miaha Cybersec <[email protected]>
…rease-code-coverage
Due to the way that mocking works with the testify testing framework in Go, mocks will expect certain mock functions to exist even if they are not necessarily called. Some mocks, such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Miaha Cybersec <[email protected]> Signed-off-by: Miaha <[email protected]> Co-authored-by: Ashna Mehrotra <[email protected]>
Related to #40