Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker repository format checks #707

Merged

Conversation

MiahaCybersec
Copy link
Contributor

@MiahaCybersec MiahaCybersec commented Jul 17, 2024

Closes #669

Copa was incorrectly exiting with an error if a Docker image was being referenced with a digest and no tag.

Signed-off-by: Miaha Cybersec <[email protected]>
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 34.22%. Comparing base (6d91446) to head (460cfc9).

Files Patch % Lines
pkg/patch/patch.go 16.66% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #707   +/-   ##
=======================================
  Coverage   34.22%   34.22%           
=======================================
  Files          18       18           
  Lines        1578     1578           
=======================================
  Hits          540      540           
  Misses       1007     1007           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashnamehrotra
Copy link
Contributor

@MiahaCybersec can we also update quick start doc with this?

@@ -51,6 +51,12 @@ This guide illustrates how to patch outdated containers with `copa`.

:::tip
If you want to patch an image using the digest, run the following command instead:

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't change it in version 0.7.0 docs since this will be a part of the next release

Copy link
Contributor

@ashnamehrotra ashnamehrotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashnamehrotra ashnamehrotra merged commit beb8c86 into project-copacetic:main Jul 23, 2024
25 checks passed
@MiahaCybersec MiahaCybersec deleted the fix-docker-format-checks branch July 29, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[REQ] Patching by sha256 digest instead tag only
2 participants