ci: build and push copa-extension image on release #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashnamehrotra <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
=======================================
Coverage 47.46% 47.46%
=======================================
Files 18 18
Lines 1677 1677
=======================================
Hits 796 796
Misses 826 826
Partials 55 55 ☔ View full report in Codecov by Sentry. |
sozercan
reviewed
Aug 10, 2024
| - name: Build and push copa-extension image with new version | ||
| run: | | ||
| tag="$(echo "${{ github.ref }}" | tr -d 'refs/tags/v')" | ||
| docker buildx build --push --platform linux/amd64,linux/arm64 --build-arg copa_version=${tag} -t copa-extension container/copa-extension |
There was a problem hiding this comment.
tag doesn't look right, is this correct?
There was a problem hiding this comment.
it should parse the tag the same way when running the ci, its following the same approach as copa-action image https://github.com/project-copacetic/copacetic/blob/main/.github/workflows/release.yml#L58-L61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...
Adds step to build and push new copa-extension image on each copa release.
Related to project-copacetic/copa-extension#5
Closes #725