Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add additional way to signoff commits #751

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

jpayne3506
Copy link
Contributor

Adds an additional way to signoff commits within CONTRIBUTING.md

@jpayne3506 jpayne3506 changed the title docs Add additional way to signoff commits docs: Add additional way to signoff commits Aug 22, 2024
@jpayne3506
Copy link
Contributor Author

Closing this loop: #750 (comment)

Also, I leveraged git rebase -i HEAD~4 --signoff to get a signoff on all of my commits as I did not know about the DCO. Perhaps this would be a good addition for https://github.com/project-copacetic/copacetic/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what?

yes! I think it would be good to document this

Copy link
Contributor

@ashnamehrotra ashnamehrotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ashnamehrotra ashnamehrotra merged commit 894500c into project-copacetic:main Aug 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants