-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[BUG] [Regression] NetBeans integration broken in 1.18.16 #2612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I understand you have errors in your code. But I'm not sure if you mean that Lombok silently didn't work, and therefore you have compiler errors since the getters were not generated, or if you suddenly get errors from Lombok code. Do you have exceptions that occurred? |
It looks like NetBeans either fails or not invoking Lombok starting in .14 version. |
Is the above clear? I feel like @rspilker you didn't understand the problem |
Screenshot above is from the .12 version of Lombok with the same project and the same setup. |
I guess I'm running into a similar issue but with
|
same here with NetBeans 12.1 and Lombok 1.18.16 ... same project, simply getter/setter/data annotations, the only change was to update Lombok from 1.18.12 to 1.18.16. |
Confirmed. Same issue with 1.18.16 |
@Rawi01 I guess you need to ensure that you installed and activated "The nb-javac java editing support library" and compile on save is enabled for your project. |
@asbachb That was the information I was missing, thanks. It should be possible to debug it now. |
Also, if you need a project, you can use this: https://github.com/flowlogix/flowlogix |
@asbachb Your problem should be fixed by the above PR |
@Rawi01 Do you have a precompiled version you can share? I can verify it within some other bigger non public projects. |
@asbachb Sure lombok.zip |
Thanks, I will try it out tomorrow. |
@Rawi01 it is better than before. The class is usable now and can be compiled. But it still has that red exclamation mark saying "Error parsing file". The error mark is shown even when only
Tested using Java 11.0.8 for Netbeans and the project. |
It looks like Netbeans uses two constructors of The one with 4 arguments as seen here https://github.com/rzwitserloot/lombok/blob/eb78f5c7665833c8e7dedce75fbe102774e370ae/src/stubs/com/sun/tools/javac/code/Symbol.java#L65 But also one with just 3 arguments here and here. The one at line 258 would be the one which would be used for setter and constructors as those methods are of Could this be the cause for the remaining parsing error? |
@sephiroth-j Thanks for testing it, this problem only occurs if the field is static, thats why I missed it. I fixed it and compiled a new version lombok.zip |
@Rawi01 For me mostly error are gone with this release. Only
|
I am getting issues with
|
@asbachb Thanks for testing, fixed that problem too. New test version: lombok.zip This bug is quite hard to fix because I can not reproduce this in a unit test. The problem is that the latest lombok version now shares method parameter names with other annotation processors. Turining of this feature in NetBeans should solve this issue but might lead to some inconsistency. |
@Rawi01 Thanks for taking a look again. I am working with NetBeans 12 and https://github.com/flowlogix/flowlogix/tree/master/jakarta-ee |
Just tested again with the new test version, unfortunately exception still occurs. Looks like
|
That's because it's using Lombok 1.18.12, if you update flowlogix-bom/pom.xml with the latest version and restart NetBeans, the problems will show up.
|
@lprimak Of course I have changed the version and fixed the |
@Rawi01 Is this with the lombok.zip from above? Or is there another, newer one I should try? |
@lprimak This one: #2612 (comment) |
@Rawi01 well, that was embarrassing, I can confirm that the new version in the above comment works correctly! |
Fixed in Lombok > 1.18.16 |
fixed by PR #2621 |
I can confirm this as well. |
Here is the same NB 12.1, The nb-javac java editing support library, lombok 1.18.16 it is still broken And NB error:
|
It seems to be fixed in edge-release (https://projectlombok.org/download-edge) Netbeans issues related to this:
Is the any ETA for a stable version with this fix? |
Yes, we need stable release |
We're currently working towards a new release, meaning we're not integrating risky features or pull requests. We expect a new release within a week. |
Good Day, Any plans for a stable release including this? |
It's been 3 months since the last release, NetBeans still broken. |
I still have this issue on Netbeans 12.3 with Lombok 1.18.20 |
Describe the bug
NetBeans "default" integration fails to process Lombok annotations,
resulting in IDE errors in Lombok projects
To Reproduce
Load a Lombok project into NetBeans IDE and see that it has errors
Expected behavior
Project is error-free
Version info (please complete the following information):
Lombok 1.18.16 and 1.18.14
MacOS, Java 8 (latest)
NetBeans 12 with the latest updates
Additional context
Just upgraded to .16 from .12 and seeing this error
The text was updated successfully, but these errors were encountered: