Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix port allocation for node-exporter #2627

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

steve-wolter-ai
Copy link

Description

The daemonset for the node exporter is statically invalid. It assigns port 9100 both to the node-exporter container and to the kube-rbac-proxy container.

This results in the following behavior at runtime:

  1. kube-rbac-proxy and node-exporter race for port 9100.
  2. If kube-rbac-proxy wins, the system functions normally. However, kube-rbac-proxy is disfunctional and does NOT actually check authorization.
  3. If kube-rbac-proxy wins, it fails to locate its upstream and crashes. The race restarts.

This change is somewhat risky as we've been (so far) rolling out node-exporter with no kube-rbac-proxy, and would now unmasks any bugs in the kube-rbac-proxy integration.

Type of change

What type of changes does your code introduce to the kube-prometheus? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Activate kube-rbac-proxy for node-exporter.


@steve-wolter-ai steve-wolter-ai requested a review from a team as a code owner March 17, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant