Consistent connection key

[basz]

A minor inconsistency; Throughout the various components the connection configuration key for persistency connections. Only in the snapshot packages 'connection_service' is the mandatory key.

https://github.com/search?q=org%3Aprooph+connection_service&type=Code

Dunno how to fix this without a BC...

[prolic]

We can introduce `connection` and fall back to `connection_service` if that key doesn't exist.

…

On Sun, Mar 25, 2018, 20:39 Bas Kamer ***@***.***> wrote: A minor inconsistency; Throughout the various components the connection configuration key for persistency connections. Only in the snapshot packages 'connection_service' is the mandatory key. https://github.com/search?q=org%3Aprooph+connection_service&type=Code Dunno how to fix this without a BC... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#19>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYEvFmFrApcOYeFjgAhsdlY4ylq9n0dks5th4_vgaJpZM4S6H4D> .

[basz]

But we can’t just make Connection required as that would break existentiële installs. Unless we can translate one to the other before the required properties are checked. I’ll investigate.

…

Op 25 mrt. 2018 om 14:44 heeft Sascha-Oliver Prolic ***@***.***> het volgende geschreven: We can introduce `connection` and fall back to `connection_service` if that key doesn't exist. On Sun, Mar 25, 2018, 20:39 Bas Kamer ***@***.***> wrote: > A minor inconsistency; Throughout the various components the connection > configuration key for persistency connections. Only in the snapshot > packages 'connection_service' is the mandatory key. > > https://github.com/search?q=org%3Aprooph+connection_service&type=Code > > Dunno how to fix this without a BC... > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#19>, or mute the > thread > <https://github.com/notifications/unsubscribe-auth/AAYEvFmFrApcOYeFjgAhsdlY4ylq9n0dks5th4_vgaJpZM4S6H4D> > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[prolic]

@sandrokeil any ideas?

[sandrokeil]

I don't think we can solve this with interop config. We need something like an alias but I don't want to add such a feature. This is not really an issue but we can fix it in next major versions.

Or do you want to introduce connection and keep connection_service key? We could remove connection_service from mandatory list and update docs to use connection. Then it would fail with an service not found exception if not configured properly. The factory could take care to check which key should be used.

[basz]

what if we;

1. remove the connection_sercvice from mandatory option
2. throw MandatoryOptionNotFoundException::missingOption($this->dimensions(), 'connection' if neither connection or connection_service is found in __invoke.
3. Oh, and update docs

Behaviour would be equal to what would happen now except for the reported key in the exception.

[sandrokeil]

Good idea, I think we can do this manually.