New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractBusFactory attachPlugins uses hardcoded vendor name iso using vendorName() #102

Closed

DannyvdSluijs opened this issue Dec 18, 2015 · 1 comment

Contributor

DannyvdSluijs commented Dec 18, 2015

At https://github.com/prooph/service-bus/blob/master/src/Container/AbstractBusFactory.php#L128 a hard coded vendor name is used in stead of the function vendorName().

When implementing the abstract bus factory and overloading vendorName() the exception would be incorrect.

Member

sandrokeil commented Dec 18, 2015

@DannyvdSluijs You're right. Do you want to make a pull request please?

codeliner added a commit that referenced this issue


          Merge pull request #103 from DannyvdSluijs/develop

0574aa9

Fixes #102

codeliner closed this as completed in

a044161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment