Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnauthorizedException not informative #136

Closed
basz opened this issue Sep 1, 2016 · 3 comments
Closed

UnauthorizedException not informative #136

basz opened this issue Sep 1, 2016 · 3 comments

Comments

@basz
Copy link
Member

basz commented Sep 1, 2016

Would it be bad to have its name present. These messages aren't useful while developing. I realise that may expose information, but I think I may want to do that anyway (I want 403 returned)

Prooph\ServiceBus\Plugin\Guard\UnauthorizedException: You are not authorized to access this resource
@prolic
Copy link
Member

prolic commented Sep 1, 2016

You want to show what? The class name or the event name?

Am 02.09.2016 06:20 schrieb "Bas Kamer" [email protected]:

Would it be bad to have its name present. These messages aren't useful
while developing. I realise that may expose information, but I think I may
want to do that anyway (I want 403 returned)

Prooph\ServiceBus\Plugin\Guard\UnauthorizedException: You are not authorized to access this resource


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#136, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYEvNx_7rjxcapwZmHw_b9xF655sbIVks5qlxdxgaJpZM4Jy-4X
.

@basz
Copy link
Member Author

basz commented Sep 2, 2016

I would say name of the denied thing. Classnames of commands

Op 2 sep. 2016 om 01:21 heeft Sascha-Oliver Prolic [email protected] het volgende geschreven:

You want to show what? The class name or the event name?

Am 02.09.2016 06:20 schrieb "Bas Kamer" [email protected]:

Would it be bad to have its name present. These messages aren't useful
while developing. I realise that may expose information, but I think I may
want to do that anyway (I want 403 returned)

Prooph\ServiceBus\Plugin\Guard\UnauthorizedException: You are not authorized to access this resource


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#136, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYEvNx_7rjxcapwZmHw_b9xF655sbIVks5qlxdxgaJpZM4Jy-4X
.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@prolic
Copy link
Member

prolic commented Sep 2, 2016

A command does not need to be a classname, see: https://github.com/prooph/service-bus/blob/master/src/CommandBus.php#L62

prolic added a commit to prolic/service-bus that referenced this issue Sep 2, 2016
@prolic prolic closed this as completed in 8b70bea Sep 2, 2016
@prolic prolic added this to the 5.2 Milestone milestone Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants