exchange PromiseInterface for ExtendedPromiseInterface

[basz]

Could we exchange \React\Promise\PromiseInterface for \React\Promise\ExtendedPromiseInterface which simply extends PromiseInterface but has the done method? see https://reactphp.org/promise/#extendedpromiseinterface

until #147 anyway

[prolic]

that's a BC break, but we can do this in next major release.

[basz]

should we have a dev branch for the next major version?

[basz]

next release will solve this: https://github.com/reactphp/promise/blob/master/CHANGELOG.md

keeping open so we don't forget

[prolic]

New branch is not needed at the moment. We just leave this ticket open and collect a few ideas. I do not have any deep plans about new major releases at the moment.

…

On Dec 29, 2017 02:39, "Bas Kamer" ***@***.***> wrote: next release will solve this: https://github.com/reactphp/ promise/blob/master/CHANGELOG.md keeping open so we don't forget — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#179 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYEvE2IxzYBzZeThl6-LPCn8JgnABXKks5tE-BlgaJpZM4ROWId> .

[basz]

next release will solve this ...

clarification: the next release of reactphp/promise.

In the new version ExtendedPromiseInterface's methods are merged into PromiseInterface. Therefore the issue I raised will become void at some point in time.

[fritz-gerneth]

Just stumpled across this issue for the same reason as @basz .

Any way curious if @prolic 's work on v8 event store will affect this implementation here too? I know amp can adapt react promises. Still would be better to have one promise implementation throughout the library?

[prolic]

I think it's better to leave react promise here. Because amp can adapt it, you can use this library with amp AND you can also use it with reactphp.

…

On Fri, Jun 15, 2018, 14:59 Fritz Gerneth ***@***.***> wrote: Just stumpled across this issue for the same reason as @basz <https://github.com/basz> . Any way curious if @prolic <https://github.com/prolic> 's work on v8 event store will affect this implementation here too? I know amp can adapt react promises. Still would be better to have one promise implementation throughout the library? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#179 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYEvOM72JJiCPyyduXitSwr1X8ZGxqvks5t81s_gaJpZM4ROWId> .