Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop java 6 support #4224

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Drop java 6 support #4224

merged 1 commit into from
Jan 25, 2018

Conversation

davido
Copy link
Contributor

@davido davido commented Jan 25, 2018

Fixes #4220.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

xfxyjwf
xfxyjwf reviewed Jan 25, 2018
View reviewed changes
BUILD
@@ -608,7 +608,6 @@ java_library(
]) + [
":gen_well_known_protos_java",
],
javacopts = ["-source 6", "-target 6"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to 7?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@davido davido force-pushed the drop_java_6_support branch from 3d67b63 to 019ceea Compare January 25, 2018 05:55
@xfxyjwf xfxyjwf merged commit 1d02e45 into protocolbuffers:master Jan 25, 2018
@davido davido deleted the drop_java_6_support branch January 25, 2018 09:20
@xuwei-k xuwei-k mentioned this pull request Jan 30, 2018
Closed
@xfxyjwf xfxyjwf self-assigned this Jun 22, 2018
@xfxyjwf xfxyjwf added the java label Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xfxyjwf xfxyjwf xfxyjwf left review comments

Assignees

@xfxyjwf xfxyjwf

Labels
cla: yes java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davido @grpc-kokoro @xfxyjwf @googlebot