Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(microsoft365): rename checks to match naming convention #7235

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

HugoPBrito
Copy link
Member

Context

We need to change Microsoft365 check names to make them match Prowler’s naming convention: prowler/providers/<provider>/services/<service>/<check_name>

Checks - Prowler Open Source Documentation

Description

All check names have been updated according to Prowler’s convention.

Checklist

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HugoPBrito HugoPBrito requested review from a team as code owners March 13, 2025 20:02
@github-actions github-actions bot added the provider/azure Issues/PRs related with the Azure provider label Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.66%. Comparing base (f2e19d3) to head (2d10e40).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7235      +/-   ##
==========================================
- Coverage   92.23%   88.66%   -3.57%     
==========================================
  Files          81     1219    +1138     
  Lines        7356    35549   +28193     
==========================================
+ Hits         6785    31521   +24736     
- Misses        571     4028    +3457     
Flag Coverage Δ
api ?
prowler 88.66% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 88.66% <100.00%> (∅)
api ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@AdriiiPRodri AdriiiPRodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR only has naming changes, we need to review the tests, the coverage is lower and in principle should be the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/azure Issues/PRs related with the Azure provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants