Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP/RFC] Cmake #664

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

[WIP/RFC] Cmake #664

wants to merge 21 commits into from

Conversation

Ziemas
Copy link
Contributor

@Ziemas Ziemas commented Oct 1, 2024

Opening a PR early in case anyone wants to help or has ideas/feedback.

@Ziemas Ziemas marked this pull request as draft October 1, 2024 18:19
@Ziemas Ziemas force-pushed the cmake branch 2 times, most recently from 515c504 to badbd14 Compare October 3, 2024 06:06
@fjtrujy
Copy link
Member

fjtrujy commented Jan 11, 2025

It would be nice to have cmake in place as I think it will help make compilation faster.
What was your blocker?

@Ziemas
Copy link
Contributor Author

Ziemas commented Jan 11, 2025

TBH I completely forgot about this for a while.

I don't think I was blocked on anything in particular, it's just kinda boring/annoying.

I think I need a different approach to that compile_multiple macro for doing per-function compilation though. IIRC the way I've done it means I can't do the ERL generation for the libraries that use it.

(You can tell that cmake was really not designed to do that type of stuff. It unfortunately makes a ton of targets which slows down single-threaded make. luckily ninja is still fast though)

@Ziemas
Copy link
Contributor Author

Ziemas commented Jan 27, 2025

Idk what to do about iopreboot. With cmake we can't build IOP code in the EE cmake project but the EE project depending on IOP doesn't seem right. Maybe we'll have to split it out further into more cmake projects.

@uyjulian
Copy link
Member

You could have a IOP subproject for imgdrv and have EE subproject iopreboot depend on that single IOP subproject only.
Then leave the IOP megaproject for common and iop subdirs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants