Skip to content

More tweaks and fixes for partial single node handling in bptree_base… #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

More tweaks and fixes for partial single node handling in bptree_base… #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions include/psi/vm/containers/b+tree.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1883,23 +1883,28 @@ auto bptree_base_wkey<Key>::flatten( std::output_iterator<Key> auto const output
}

template <typename Key>
auto bptree_base_wkey<Key>::flatten( const_iterator const begin, const_iterator const end, std::output_iterator<Key> auto output, size_type const available_space ) const noexcept {
auto bptree_base_wkey<Key>::flatten( const_iterator const begin, const_iterator const end, std::output_iterator<Key> auto output, size_type available_space ) const noexcept {
BOOST_ASSERT( available_space >= static_cast<std::size_t>( std::distance( begin, end ) ) );
auto const end_pos{ end.base().pos() };
auto start_pos{ begin.base().pos() };
if ( start_pos.value_offset ) // handle leading partial node
{
auto const & lf{ leaf( start_pos.node ) };
BOOST_ASSUME( start_pos.value_offset < lf.num_vals );
auto const copy_end{ ( start_pos.node != end_pos.node ) ? lf.num_vals : end_pos.value_offset };
auto const copy_size{ copy_end - start_pos.value_offset };
auto const single_node{ start_pos.node == end_pos.node };
node_header::size_type const copy_end { !single_node ? lf.num_vals : end_pos.value_offset };
node_header::size_type const copy_size( copy_end - start_pos.value_offset );
BOOST_ASSUME( copy_size <= available_space );
output = std::uninitialized_copy_n( &lf.keys[ start_pos.value_offset ], copy_size, output );
if ( copy_size == available_space ) [[ unlikely ]] // single (partial) node data
if ( single_node ) [[ unlikely ]] { // single (partial) node data
BOOST_ASSUME( copy_size == available_space );
return output;
}
BOOST_ASSUME( copy_size < available_space );
available_space -= copy_size;
start_pos.value_offset += copy_size;
if ( start_pos.value_offset == lf.max_values )
start_pos = { lf.right, 0 };
BOOST_ASSUME( start_pos.value_offset == lf.num_vals );
start_pos = { lf.right, 0 };
}

if ( start_pos.node != end_pos.node )
Expand Down
Loading