Remote Notification Type #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
===========================================
+ Coverage 83.18% 97.02% +13.83%
===========================================
Files 29 16 -13
Lines 1249 538 -711
Branches 38 0 -38
===========================================
- Hits 1039 522 -517
+ Misses 210 16 -194
Continue to review full report at Codecov.
|
lukabratos
commented
Apr 9, 2018
Sources/EventTypeHandler.swift
Outdated
| let pusher = data["pusher"] as? Dictionary<String, Any> | ||
| else { return .Other } | ||
|
|
||
| return pusher["isInternalOnly"] != nil ? .Internal : .Other |
There was a problem hiding this comment.
If we have isInternalOnly value in the payload we know that it's internal remote notification.
Other doesn't sound right to me - it needs to be renamed.
lukabratos
changed the base branch from
update-to-recommended-settings
to
master
lukabratos
force-pushed
the
remote-notification-type
branch
from
a33b90f to
a65e998
Compare
Sources/EventTypeHandler.swift
Outdated
| @@ -67,4 +67,13 @@ struct EventTypeHandler { | |||
| // Returns `true` if there is any additional information provided. | |||
| return data.count > 1 | |||
| } | |||
|
|
|||
| static func isInternalNotification(_ userInfo: [AnyHashable: Any]) -> RemoteNotificationType { | |||
There was a problem hiding this comment.
getRemoteNotificationType
added 2 commits
April 24, 2018 10:19
lukabratos
force-pushed
the
remote-notification-type
branch
from
3f45908 to
35dd774
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Usage:
CC @pusher/mobile