refactor(logitech_receiver/hidppx0_constants.py): replace ERROR NamedInt by IntEnum #2645
Conversation
…Error and BoltPairingError
…Error and BoltPairingError (Fix pre-commit checks)
…ion before replacing ERRORNamedInts by IntEnum
…nction before replacing ERROR NamedInts by IntEnum
…ion before replacing ERRORNamedInts by IntEnum (add exclusion for macOS)
…ion before replacing ERRORNamedInts by IntEnum (fix for python < 3.10)
…fore replacing ERROR NamedInts by IntEnum (focusing on the call order when receiving errors)
…e short and long registers in a single loop structure for improved readability and reduced code duplication.
… and hidpp20 errors in the code for readibility.
…Int by IntEnum. (fix problem with | operator when typing with python 3.8)
rloutrel
changed the title
|
Is Ok. I am on this problem... |
…fore replacing ERROR NamedInts by IntEnum (focusing on the call order when receiving errors)
…e short and long registers in a single loop structure for improved readability and reduced code duplication.
…Int by IntEnum. (fix problem with | operator when typing with python 3.8)
|
Ready for merge. I will stop on re-factoring to try the implementation of something like a configuration (and menu in app) if you agree and think it is a good idea. |
I wouldn't recommend it, as the existing code needs so much clean up and improvement, that it's better to do that first. Otherwise it is likely that the mess grows and grows. We should aim for further restructuring into a well testable business logic, that is not directly dependent on files or the user interface, as proposed in "Architecture Patterns with Python: Enabling Test-Driven Development, Domain-Driven Design, and Event-Driven Microservices". |
Also did a small refactoring in run, for readibility (and reduce duplicated code)