Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Initial finch_backend #649

Merged
merged 2 commits into from
Mar 14, 2024
Merged

API: Initial finch_backend #649

merged 2 commits into from
Mar 14, 2024

Conversation

mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented Mar 13, 2024

Initial finch_backend setup.

Copy link

github-actions bot commented Mar 13, 2024

Test Results

5 900 tests  +1   5 864 ✅  - 3   5m 18s ⏱️ + 1m 59s
    1 suites ±0      36 💤 +4 
    1 files   ±0       0 ❌ ±0 

Results for commit 0650e70. ± Comparison against base commit 32e6e0b.

This pull request skips 5 and un-skips 1 tests.
sparse.pydata_backend.tests.test_compressed ‑ test_reductions_float16[f4-None-sum-kwargs0]
sparse.pydata_backend.tests.test_compressed ‑ test_reductions_float16[i4-None-sum-kwargs0]
sparse.pydata_backend.tests.test_compressed ‑ test_reductions_float16[i8-None-sum-kwargs0]
sparse.pydata_backend.tests.test_coo ‑ test_reductions_float16[f4-None-sum-kwargs0]
sparse.pydata_backend.tests.test_coo ‑ test_reductions_float16[i4-None-sum-kwargs0]
sparse.pydata_backend.tests.test_compressed ‑ test_reductions_float16[f8-None-sum-kwargs0]

♻️ This comment has been updated with latest results.

@mtsokol mtsokol force-pushed the juliacall-segfault branch 2 times, most recently from 187dad1 to db81bc4 Compare March 14, 2024 09:50
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small comments.

@mtsokol mtsokol force-pushed the juliacall-segfault branch 5 times, most recently from e7199e4 to 85f7743 Compare March 14, 2024 10:24
@mtsokol mtsokol force-pushed the juliacall-segfault branch from 85f7743 to 65fc388 Compare March 14, 2024 10:43
@mtsokol mtsokol changed the title Reproduce: JuliaCall segfault API: Initial finch_backend Mar 14, 2024
@mtsokol mtsokol force-pushed the juliacall-segfault branch from 65fc388 to 5edc8fe Compare March 14, 2024 13:05
Co-authored-by: Hameer Abbasi <[email protected]>
@mtsokol mtsokol force-pushed the juliacall-segfault branch from 5edc8fe to 33f75c3 Compare March 14, 2024 13:21
@mtsokol mtsokol requested a review from hameerabbasi March 14, 2024 13:30
@mtsokol
Copy link
Collaborator Author

mtsokol commented Mar 14, 2024

@hameerabbasi The PR is ready from my side. It contains initial finch-tensor setup where we can run and test existing Tensor API. In the next steps I will start moving pydata_backend tests to a common tests directory and test against common Array API (once we have it in finch-tensor).

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change and this looks good to go.

@hameerabbasi hameerabbasi enabled auto-merge (squash) March 14, 2024 16:04
@hameerabbasi hameerabbasi merged commit adfdf04 into main Mar 14, 2024
9 checks passed
@hameerabbasi hameerabbasi deleted the juliacall-segfault branch March 14, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants