-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add class-resolver
for Aggregation
#4716
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4716 +/- ##
=======================================
Coverage 82.40% 82.40%
=======================================
Files 321 321
Lines 17207 17209 +2
=======================================
+ Hits 14179 14181 +2
Misses 3028 3028
Continue to review full report at Codecov.
|
schönes Feierabend btw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR :)
@@ -11,6 +11,7 @@ | |||
'requests', | |||
'pyparsing', | |||
'scikit-learn', | |||
'class_resolver', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot add class-resolver
package back in since it is not available on anaconda.org. That's why we started writing our own solution for that (with a limited feature set): https://github.com/pyg-team/pytorch_geometric/blob/master/torch_geometric/nn/resolver.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I can look into putting it in conda
class-resolver
for Aggregation
As a follow-up to #4687, this pull request adds a
class-resolver
for aggregations intorch_geometric.nn.aggr
. It also adds a class docstring with an example on how to use it.Note that
class_resolver
is a pure python package with no dependencies.