Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Remove duplicate node_types in NeighborSampler with FeatureStore #4856

Merged
merged 4 commits into from
Jun 24, 2022

Conversation

ZenoTan
Copy link
Member

@ZenoTan ZenoTan commented Jun 24, 2022

Also fixed a return type typo.

@ZenoTan ZenoTan requested review from mananshah99 and rusty1s June 24, 2022 12:43
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #4856 (2fd437f) into master (7a89399) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4856   +/-   ##
=======================================
  Coverage   82.80%   82.80%           
=======================================
  Files         329      329           
  Lines       17713    17713           
=======================================
  Hits        14668    14668           
  Misses       3045     3045           
Impacted Files Coverage Δ
torch_geometric/data/feature_store.py 88.23% <ø> (ø)
torch_geometric/loader/neighbor_loader.py 87.19% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a89399...2fd437f. Read the comment docs.

@ZenoTan ZenoTan self-assigned this Jun 24, 2022
@rusty1s rusty1s merged commit 78bbfbd into master Jun 24, 2022
@rusty1s rusty1s deleted the zy_fix branch June 24, 2022 13:13
@ZenoTan ZenoTan changed the title Hotfix: Remove duplicate node_types in NeighborLoader with FeatureStore Hotfix: Remove duplicate node_types in NeighborSampler with FeatureStore Jun 24, 2022
rusty1s added a commit that referenced this pull request Jun 24, 2022
* fix

* fix test

Co-authored-by: rusty1s <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants