Typos and remove always true condition #7008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
the
Skip news 🔇
jacobtylerwalls
commented
Jun 23, 2022
| @@ -1799,7 +1799,6 @@ def in_type_checking_block(node: nodes.NodeNG) -> bool: | |||
| if ( | |||
| isinstance(inferred_module, nodes.Module) | |||
| and inferred_module.name == "typing" | |||
| and inferred_module.pytype() == "builtins.module" | |||
There was a problem hiding this comment.
From #6787, always true, it turns out.
| @@ -249,7 +249,7 @@ class PyLinter( | |||
| * handle some basic but necessary stats' data (number of classes, methods...) | |||
|
|
|||
| IDE plugin developers: you may have to call | |||
| `astroid.builder.MANAGER.astroid_cache.clear()` across runs if you want | |||
| `astroid.MANAGER.clear_cache()` across runs if you want | |||
There was a problem hiding this comment.
This now matches the guidance in doc/development_guide/api/pylint.rst
Pull Request Test Coverage Report for Build 2546346103
💛 - Coveralls |
This comment has been minimized.
This comment has been minimized.
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 5956509 |
Pierre-Sassoulas
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes