[Backport maintenance/2.17.x] Fix incorrect preferred-modules matches #8481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: d33bs <[email protected]> (cherry picked from commit d64c0cc)
|
@Pierre-Sassoulas Do we even merge this now that we have cut off |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## maintenance/2.17.x #8481 +/- ##
===================================================
Coverage 95.56% 95.56%
===================================================
Files 178 178
Lines 18779 18779
===================================================
Hits 17947 17947
Misses 832 832
|
|
Yes 2.17 is the last minor. The question is more 'should we keep two minors maintenance branch once 3.0.0 is out ?'. I think we should keep the possibility but I don't think it's that valuable for users frankly. |
Pierre-Sassoulas
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport d64c0cc from #8454.