Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor pyreverse tests to use temporary directory #8529

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

DudeNr33
Copy link
Collaborator

@DudeNr33 DudeNr33 commented Apr 2, 2023

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

See #8517 (comment)
Turned out that by using the monkeypatch fixture there is no need to touch the existing tests.

@DudeNr33 DudeNr33 added pyreverse Related to pyreverse component Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news πŸ”‡ This change does not require a changelog entry labels Apr 2, 2023
@DudeNr33 DudeNr33 added this to the 3.0.0b1 milestone Apr 2, 2023
@DudeNr33 DudeNr33 self-assigned this Apr 2, 2023
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you !

@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Merging #8529 (76dfc80) into main (6ad17fb) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8529   +/-   ##
=======================================
  Coverage   95.90%   95.90%           
=======================================
  Files         174      174           
  Lines       18365    18365           
=======================================
  Hits        17613    17613           
  Misses        752      752           

@DudeNr33 DudeNr33 merged commit 0ec3c7f into pylint-dev:main Apr 2, 2023
@DudeNr33 DudeNr33 deleted the refactor-pyreverse-tests branch April 2, 2023 14:32
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 3.0.0b1, 3.0.0a7 May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow pyreverse Related to pyreverse component Skip news πŸ”‡ This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants