-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SyntaxError around async keyword on Python 3.7 #956
Comments
This should be raised on https://github.com/pexpect/pexpect/ I imagine this change in 3.7 is going to break a whole lot of code though. |
This might have helped surface https://github.com/kennethreitz/pipenv/issues/956 sooner.
It looks like they have already fixed this issue upstream ( |
So I think the vendored pexpect just needs to be updated. |
I closed #957 because I don't think we want the noise from tests failing until 3.7 is at least into a beta phase. I'll get pexpect updated tonight. Thanks everyone! |
update the vendored pexpect for python 3.7 async support to fix #956
This is fixed on master by PR #962 |
I am facing the same issue as well. Please advise. |
the async as variable issue also breaks apache-airflow on python 3.7. |
The pexpect issue has been fixed long ago. If you see this exact problem, you should upgrade Pipenv. If Pipenv is already up-to-date, or if you’re experiencing this for a package you want to install with Pipenv, this is a problem of that package, not Pipenv. Please report this problem to them instead. Locking this since the problem is obviously resolved, and any claim of having this exact issue is always wrong. |
async
cannot be used as an argument name in Python 3.7:https://github.com/kennethreitz/pipenv/blob/d89696e36da1277067c055ca83f786f762f02091/pipenv/vendor/pexpect/spawnbase.py#L224
Describe you environment
Expected result
I can install pipenv.
Actual result
Steps to replicate
pip install pipenv
with Python 3.7.The text was updated successfully, but these errors were encountered: