-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash under Python 2 #2134
Crash under Python 2 #2134
Conversation
…rs to the latest guidance. Fixes #2094.
@McSinyx I'd be interested in your feedback as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaraco, personally I believe this would give users better guidance. I also spot that in the issue template
To ease the transition, Setuptools 45 was released to continue to have Python 2 compatibility, but emit a strenuous warning that it will stop working.
and wonder if you want to remove this given setuptools will crash on purpose and that we're on version 46+ now. If this PR is to be merged with the crashing part, I think it is fair to bump the version to 47 for backward compatible distinction.
.github/ISSUE_TEMPLATE/setuptools-warns-about-python-2-incompatibility.md
Show resolved
Hide resolved
Good feedback. I was leaning away from make it an incompatible release because the guidance is unchanged (use |
cac5d3f
to
e0b3acb
Compare
Thanks for the feedback. I'll plan to release this tomorrow unless there are other emergent concerns. |
Okay. So today I learned that Bit.ly link targets can't be updated, at least not without a paid plan, and even then seemingly not without a custom domain. I was expecting that was one main advantage to using bit.ly (right after shorter urls). I guess that means that users on setuptools 45 and 46 will always be directed to the bug or bug template :/. |
Sorry I never responded to this, I'm fine with fully dropping support. Doesn't look like there's much progress in any of the stuff where I was worried that adoption would be held back by anyway, and we can't wait forever. |
This change fully drops support for Python 2 on the master branch, causing an explicit crash if it happens to be installed and executed on Python 2.
Adds new documentation (to which the bit.ly link will point), giving users the best guidance we have today (and in the future) and ultimately leading to the issue template.
There's a part of me that's tempted to release this not as a backward-incompatible release, as the backward-incompatible release was 45.0 and this change is only an enforcement of that incompatibility that's been guarded by a warning since the 45 release.
Fixes #2094.