-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make mock only optional dependency #3965
Comments
why not just go ahead and make a pr of this |
Because I don't want to keep around clones with hundreds of silly Python projects I fix (I am a maintainer of Python for a large Linux distro). |
good luck with that |
Thanks for the patch, I've created #3967 (let me know if you want to take credit for it!). I think it is fair to not having to create PRs: this is usually easy for a contributor that has it checked out already, and it allows to fine-tune e.g. the tox.ini like I did now. |
Thanks for PR. Yeah, I don't care that much about attribution, it is not really a great feat of computer engineering after all. |
Fixes pytest-dev#3965. Has to work around tox-dev/tox#706. No coverage for pluggymaster builds is OK though anyway.
@mcepl |
Just a side note: given the specialities with tox etc that showed itself up in the PR I can totally understand that a simple patch is far from getting this finished correctly, and therefore it is very valid to just report issues and provide patches. @RonnyPfannschmidt @nicoddemus (who downvoted the comment) |
No, to my patch. Although I have some gripes with |
Fixes pytest-dev#3965. Has to work around tox-dev/tox#706. No coverage for pluggymaster builds is OK though anyway.
When packaging
pytest
in Linux distributions (and I guess it matters for other packaging systems as well, e.g., MacPorts or Homebrew), especially for packages which are deep in the tree of dependencies, it is useful to remove all unnecessary dependencies. That's a case ofmock
, which is since Python 3.3 available in the standard library asunittest.mock
.This patch makes the
mock
only optional dependency ofpytest
.The text was updated successfully, but these errors were encountered: