fix: re-enable SSR #610
Closed
fix: re-enable SSR #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be quite honest, I'm not sure if this is safe or what it might break (or why this was ever done in the first place). However, having SSR disabled is causing some docs pages to have terrible performance and people are complaining. I did some testing with this and I didn't see any issues. At this point I believe the best path forward is to re-enable SSR and just fix forward if we find any issues I missed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Closing this as it did not have the expected impact on performance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be quite honest, I'm not sure if this is safe or what it might break (or why this was ever done in the first place). However, having SSR disabled is causing some docs pages to have terrible performance and people are complaining.
I did some testing with this and I didn't see any issues. At this point I believe the best path forward is to re-enable SSR and just fix forward if we find any issues I missed