Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more granular price fetching #60

Closed
cryptopapi997 opened this issue Jan 29, 2023 · 3 comments
Closed

Add more granular price fetching #60

cryptopapi997 opened this issue Jan 29, 2023 · 3 comments

Comments

@cryptopapi997
Copy link
Contributor

cryptopapi997 commented Jan 29, 2023

Thanks for the great SDK guys!
One request, though: It is currently only possible to fetch and listen to every single price feed at once and parse afterwards. This differs from the rust SDK where we can listen to individual price feeds, which is far more useful, as it significantly reduces parsing overhead for the client. Adding functionality to fetch / listen to individual price feeds would be a great improvement imo. I've found parsePriceData to parse individual accounts, but am wondering if this is recommended to use like that.

@jayantk
Copy link
Contributor

jayantk commented Jan 30, 2023

Hey thank you for the suggestion. Fetching/listening to individual feeds is definitely possible, though it isn't high on our priority list at the moment. We would definitely accept a community PR to implement that functionality though.

I think the PR would be pretty straightforward -- all you have to do is query for single solana accounts (using their api) and then call parsePriceData on the result.

@cryptopapi997
Copy link
Contributor Author

Sounds good, just created a PR #61

@jayantk
Copy link
Contributor

jayantk commented Feb 2, 2023

Resolved by #61

@jayantk jayantk closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants