Add method to fetch individual prices specified by user #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks great to me. add a test and i'll approve. I think throwing makes sense in this context (it suggests a user misconfiguration of the feed ids) so i'm happy with that choice. |
|
Great! Just added tests & removed a duplicate test file you guys still had in there while I was at it |
|
lmk if that works @jayantk |
|
I cut a release with the new functionality as well https://github.com/pyth-network/pyth-client-js/releases/tag/v2.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be pretty straightforward - Lmk if this works and I'll add tests.
I opted to allow for passing an array of price accounts, as this allows for fetching one price account if needed, but allows for the optimization of using
getMultipleAccountsInfounder the hood for the case that more than one account is needed.Also couldn't quite tell from the rest of the library if you guys prefer throwing or returning empty objects (or null or undefined) for invalid data. I opted for throwing for now.