Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize rpc calls #71

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Optimize rpc calls #71

merged 1 commit into from
Jun 20, 2023

Conversation

cryptopapi997
Copy link
Contributor

  • Getting slot and program accounts was being called synchronously in many spots where it could've been called concurrently. This PR changes this.
  • Increases the response time anywhere between 500ms and 1000ms when testing locally

@cryptopapi997
Copy link
Contributor Author

lmk if these changes make sense or not for this library, I think it could improve performance in a significant way for a decent amount of existing apps @guibescos @jayantk

jayantk
jayantk approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me! thanks for the PR!

@jayantk jayantk merged commit 5e8b65b into pyth-network:main Jun 20, 2023
@cryptopapi997
Copy link
Contributor Author

Awesome, thanks for the quick response :) . Could you also cut a new release so dependents can start using this?

@guibescos
Copy link
Contributor

Release shipped, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantk jayantk jayantk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cryptopapi997 @guibescos @jayantk