Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix next_market_open for fx and metal #39

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Conversation

cctdaniel
Copy link
Contributor

@cctdaniel cctdaniel commented Aug 23, 2023

the previous logic had a bug where if the time given is a weekday and its before 10pm utc, it will return the same day 10pm utc when it should be returning the next Sunday at 10pm utc

Copy link
Contributor

@ali-bahjati ali-bahjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't very easy for me to understand the code at first but it looks good. I think some documentation explaining how the logic works can help future developers.

@cctdaniel cctdaniel merged commit 591f87d into main Aug 23, 2023
@cctdaniel cctdaniel deleted the calendar_next_market_open branch August 23, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants