fix fx bug and add 2024 calendar #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-bahjati
reviewed
Dec 25, 2023
| @@ -60,7 +74,7 @@ def is_market_open(asset_type: str, dt: datetime.datetime) -> bool: | |||
| return False | |||
|
|
|||
| if asset_type in ["fx", "metal"]: | |||
| if date in FX_METAL_HOLIDAYS: | |||
| if date in FX_METAL_HOLIDAYS and time < FX_METAL_OPEN_CLOSE_TIME: | |||
There was a problem hiding this comment.
did you double check this?
ali-bahjati
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously calendar would return
is_market_open = Truefor FX if its after Sunday 5pm ET but next day is a holiday when it should beFalse