Use message structures defined in pythnet sdk #377
Conversation
Since the custom serialization implementations are solana specific and mainly for reducing the binary size, they are kept in this package via a custom trait. Deserialization functions were removed since they were not used and the default serde provided by pythnet sdk should work identically. Serialization tests are now repurposed to test our custom serialization and the general deserialization lead to the same original structure.
| } | ||
| } | ||
|
|
||
| #[quickcheck] | ||
| fn test_twap_message_roundtrip(input: TwapMessage) -> bool { | ||
| let reconstructed = TwapMessage::try_from_bytes(&input.to_bytes()); | ||
| let reconstructed = from_slice::<BigEndian, Message>(&input.to_bytes()).unwrap(); |
There was a problem hiding this comment.
just to be clear about this: If the message struct changes (e.g., we add a field in the SDK), and then we upgrade the dependency here, this test will fail because the generator for the message will be upgraded, but to_bytes() will not be. (I think that is a good thing, but I want to make sure that is what will hapeen)
The old resolver adds the quickcheck feature on the pythnet-sdk dependency for non-dev builds as well which leads to compile errors.
|
Size changes:
|
| pub fn to_bytes(self) -> [u8; Self::MESSAGE_SIZE] { | ||
| let mut bytes = [0u8; Self::MESSAGE_SIZE]; | ||
| fn to_bytes(self) -> Vec<u8> { | ||
| const MESSAGE_SIZE: usize = 1 + 32 + 16 + 16 + 8 + 4 + 8 + 8 + 8; |
There was a problem hiding this comment.
I think MESSAGE_SIZE and DISCRIMINATOR could be constants in the trait PythOracleSerialize
There was a problem hiding this comment.
I discussed this with Ali, we were thinking of moving the DISCRIMINATOR serialization part to the Message enum and implement to_bytes for it as well as the next step. This would lead to PythOracleSerialize becoming more abstract and not having a fixed discriminator/message_size. That's why we kept it like this.
Since the custom serialization implementations are solana specific and mainly for reducing the binary size, they are kept in this package via a custom trait.
Deserialization functions were removed since they were not used and the default serde provided by pythnet sdk should work identically. Serialization tests are now repurposed to test our custom serialization and the general deserialization lead to the same original structure.