add support to configure max latency #391

cctdaniel · 2024-02-15T06:11:29Z

add configurable max latency in slots between send and receive

for price feeds with more publishers this can be reduced instead of using the default 25 value to reduce latency

cctdaniel · 2024-02-15T06:12:01Z

program/c/src/oracle/oracle.h

@@ -195,8 +195,9 @@ typedef struct pc_price
  pc_ema_t        twac_;              // time-weighted average conf interval
  int64_t         timestamp_;         // unix timestamp of aggregate price
  uint8_t         min_pub_;           // min publishers for valid price
-  int8_t          drv2_;              // space for future derived values
-  int16_t         drv3_;              // space for future derived values
+  int8_t          message_sent_;      // flag to indicate if the current aggregate price has been sent as a message to the message buffer, 0 if not sent, 1 if sent


drive-by: this was already changed in the rust program previously but wasn't changed here

cctdaniel · 2024-02-15T06:12:45Z

program/c/src/oracle/oracle.h

-  int8_t          drv2_;              // space for future derived values
-  int16_t         drv3_;              // space for future derived values
+  int8_t          message_sent_;      // flag to indicate if the current aggregate price has been sent as a message to the message buffer, 0 if not sent, 1 if sent
+  uint8_t         max_latency_;       // configurable max latency in slots between send and receive


we only need uint8_t for max_latency_ so splitting it to uint8_t and int8_t

program/rust/src/tests/test_twap.rs

program/rust/src/tests/test_upd_aggregate.rs

program/c/src/oracle/upd_aggregate.h

program/rust/src/tests/test_upd_aggregate.rs

ali-bahjati

Very nice! I will look again after you addressed the feedbacks (just to be extra careful).

program/rust/src/tests/test_twap.rs

program/rust/src/tests/test_upd_aggregate.rs

program/c/src/oracle/upd_aggregate.h

ali-bahjati

Nice! I left some minor comments.

ali-bahjati

Nice! I left some minor comments.

cctdaniel commented Feb 15, 2024

View reviewed changes

cctdaniel added 3 commits February 16, 2024 10:30

add initial code to support max latency

38d6850

fix precommit

796a762

fix tests

74c6366

cctdaniel force-pushed the max-latency branch from ceeada2 to 74c6366 Compare February 16, 2024 01:31

add more tests

79cb509

cctdaniel marked this pull request as ready for review February 19, 2024 11:24

cctdaniel changed the title ~~add initial code to support max latency~~ add code to support max latency Feb 19, 2024

cctdaniel changed the title ~~add code to support max latency~~ add support to configure max latency Feb 19, 2024