refactor: remove pythnet feature flag #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cctdaniel
changed the title
cctdaniel
changed the title
ali-bahjati
reviewed
Mar 22, 2024
ali-bahjati
reviewed
Mar 22, 2024
guibescos
reviewed
Mar 25, 2024
guibescos
reviewed
Mar 25, 2024
guibescos
reviewed
Mar 25, 2024
cctdaniel
force-pushed
the
remove-solana
branch
from
df90936 to
a43a6a0
Compare
guibescos
reviewed
Mar 26, 2024
guibescos
reviewed
Mar 26, 2024
guibescos
previously approved these changes
Mar 26, 2024
cctdaniel
commented
Mar 27, 2024
| @@ -20,7 +20,7 @@ set -x | |||
| cd "${PYTH_DIR}" | |||
|
|
|||
| # Re-run tests affected by features | |||
| cargo test --locked | |||
| cargo-test-bpf | |||
There was a problem hiding this comment.
cargo-test-bpf doesn't work with -- --locked
guibescos
previously approved these changes
Mar 27, 2024
cctdaniel
commented
Mar 27, 2024
| + PC_NUM_COMP * sizeof(pc_price_comp_t) \ | ||
| ) | ||
|
|
||
| static_assert( sizeof( pc_price_t ) == PC_EXPECTED_PRICE_T_SIZE_PYTHNET, "" ); | ||
| #undef PC_EXPECTED_PRICE_SIZE_PYTHNET | ||
| #undef PC_EXPECTED_PRICE_T_SIZE_PYTHNET |
There was a problem hiding this comment.
this seems like a typo before
ali-bahjati
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solana specific code is duplicated in https://github.com/pyth-network/pyth-client/tree/solana so we have a fallback in case we need to make any fix