refactor: optimize some checks on upd_price #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ali-bahjati
commented
May 13, 2024
•
ali-bahjati
commented
- Remove rent check because it costs 500CU (+10% of upd_price without aggregate) and it really is not needed.
- Use abs() on checking confidence threshold because it's incredibly slow on negative prices (2000CU). We don't have negative prices but will guard us in the future.
- Remove rent check on hot code path because it costs 500CU and add/remove instructions take care of it. - Use abs() on checking confidence threshold because it's incredibly slow on negative prices (2000CU). We don't have negative prices but will guard us in the future.
ali-bahjati
requested review from
jayantk,
guibescos and
Reisen
and removed request for
jayantk and
guibescos
jayantk
previously approved these changes
May 13, 2024
guibescos
reviewed
May 13, 2024
| @@ -123,7 +123,7 @@ pub fn upd_price( | |||
| }?; | |||
|
|
|||
| check_valid_funding_account(funding_account)?; | |||
| check_valid_writable_account(program_id, price_account)?; | |||
| check_valid_writable_account_without_rent_check(program_id, price_account)?; | |||
There was a problem hiding this comment.
mmmmm what about removing the rent check everywhere? I think the check is not useful anywhere
There was a problem hiding this comment.
this is introducing more complexity
ali-bahjati
force-pushed
the
optimize/optimize-checks
branch
from
d8be0a7 to
2996b13
Compare
guibescos
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.