feat: Delayed block processing for Fortuna #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
…lays Co-Authored-By: Jayant Krishnamurthy <[email protected]>
jayantk
reviewed
Jan 30, 2025
apps/fortuna/src/keeper.rs
Outdated
| @@ -975,12 +979,14 @@ pub async fn process_new_blocks( | |||
| escalation_policy: EscalationPolicyConfig, | |||
| metrics: Arc<KeeperMetrics>, | |||
| fulfilled_requests_cache: Arc<RwLock<HashSet<u64>>>, | |||
| chain_eth_config: EthereumConfig, | |||
There was a problem hiding this comment.
please pass only the block delay parameter here (not the whole config)
jayantk
reviewed
Jan 30, 2025
apps/fortuna/src/keeper.rs
Outdated
| for delay in &chain_eth_config.block_delays { | ||
| let adjusted_range = BlockRange { | ||
| from: block_range.from + delay, | ||
| to: block_range.to + delay, |
There was a problem hiding this comment.
the delay should be subtracted not added
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
jayantk
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configurable delayed block processing to Fortuna keeper with support for multiple delays.
Changes:
Link to Devin run: https://app.devin.ai/sessions/ee151071e71646d18a712d8ce3af4e0f