(chore): Fortuna refactor #2372
Merged
+1,543
−1,444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jayantk
commented
Feb 12, 2025
| tracing, | ||
| }; | ||
|
|
||
| pub async fn send_and_confirm<A: Middleware>(contract_call: ContractCall<A, ()>) -> Result<()> { |
There was a problem hiding this comment.
Note: the function signatures of this function and the one below changed very slightly so that they don't depend on the pyth-specific type declarations in the chain/ module.
m30m
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure move PR that just moves logic around to help isolate reusable ethereum transaction logic. I made a new eth_utils module to hold the reusable stuff. I also split out the contents of the keeper file into multiple files in the new keeper module.
There is still some refactoring to do around process_event and the escalator policy and such, but i will do that separately. The modules can also be renamed, but again i will address later.