Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(staking): fix header on small screens 2: This Time It's Personal #2483

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

cprussin
Copy link
Collaborator

Summary

More fixes for #2482 .

Rationale

The fix in #2482 did not account for the header state when the wallet is connected, which additionally shows the current stake account and requires more space.

How has this been tested?

Before:
screenshot-2025-03-13-101845

After:
screenshot-2025-03-13-101851

@cprussin cprussin requested a review from guibescos March 13, 2025 17:20
@cprussin cprussin requested a review from a team as a code owner March 13, 2025 17:20
Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 5:22pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Mar 13, 2025 5:22pm
component-library ⬜️ Ignored (Inspect) Mar 13, 2025 5:22pm
entropy-debugger ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2025 5:22pm
insights ⬜️ Ignored (Inspect) Mar 13, 2025 5:22pm
proposals ⬜️ Ignored (Inspect) Mar 13, 2025 5:22pm

@@ -74,7 +74,7 @@ export const AccountSummary = ({
<Image
src={background}
alt=""
className="absolute -right-40 hidden h-full object-cover object-right [mask-image:linear-gradient(to_right,_transparent,_black_50%)] md:block"
className="absolute -right-40 hidden h-full object-cover object-right [mask-image:linear-gradient(to_right,_transparent,_black_50%)] sm:block"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change but just something I noticed looked odd, the account summary background wasn't showing up on small screens where it should have been

@cprussin cprussin merged commit 534006d into main Mar 13, 2025
10 checks passed
@cprussin cprussin deleted the cprussin/fix-staking-header-2-this-time-its-personal branch March 13, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants