Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps/price_pusher): add prom metrics #2491

Merged
merged 18 commits into from
Mar 19, 2025
Merged

Conversation

cctdaniel
Copy link
Contributor

@cctdaniel cctdaniel commented Mar 17, 2025

Summary

Added comprehensive monitoring capabilities to the price_pusher service, including:

  • Prometheus metrics for tracking service health, performance, and wallet balances
  • Grafana dashboard configuration for visualizing metrics
  • Alerting configuration for critical service conditions
  • Docker Compose setup for easy deployment of the monitoring stack
  • Documentation updates in README for monitoring features

Rationale

These changes are necessary to improve the observability of the price_pusher service, enabling operators to:

  1. Monitor the health and performance of price feeds in real-time
  2. Track wallet balances to prevent transaction failures due to insufficient funds
  3. Receive timely alerts when issues occur
  4. Easily deploy and configure the monitoring infrastructure
  5. Have comprehensive documentation on the monitoring capabilities

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

The monitoring functionality has been manually verified by:

  1. Running the service with metrics enabled
  2. Confirming metrics are correctly exposed on the configured port
  3. Testing the Docker Compose setup to ensure Prometheus and Grafana services start correctly
  4. Verifying that metrics are properly collected in Prometheus
  5. Confirming the Grafana dashboard displays all metrics as expected
  6. Testing alert conditions to ensure they trigger appropriately
  7. Validating wallet balance tracking accurately reflects on-chain balances

@cctdaniel cctdaniel requested a review from a team as a code owner March 17, 2025 09:35
Copy link

vercel bot commented Mar 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 2:05pm
component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 2:05pm
entropy-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 2:05pm
insights ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 2:05pm
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 2:05pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 2:05pm

Copy link
Collaborator

@ali-bahjati ali-bahjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the code now. The only request i have is to respect the design structure of the code. I recommend you add the balance tracker interface to the top interfaces.ts and later implement the one for evm in the evm directory.

Copy link
Collaborator

@ali-bahjati ali-bahjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! can you bump the version as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants