fix: fix broken wallet adapter in proposals app #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cprussin
commented
Mar 17, 2025
| LedgerWalletAdapter, | ||
| PhantomWalletAdapter, | ||
| SolflareWalletAdapter, | ||
| SolletExtensionWalletAdapter, | ||
| SolletWalletAdapter, |
There was a problem hiding this comment.
fyi @guibescos these wallet adapters have been deprecated and no longer exist in the current version of the solana wallet adapter library.
cprussin
commented
Mar 17, 2025
| @@ -24,6 +24,9 @@ | |||
| "pnpm": { | |||
| "overrides": { | |||
| "@solana/[email protected]>rpc-websockets": "7.11.0" | |||
| }, | |||
| "patchedDependencies": { | |||
| "[email protected]": "patches/[email protected]" | |||
There was a problem hiding this comment.
I removed this patch in #2489 and the proposals app works in prod without it, but I didn't test local dev mode, and there without this patch we get a syntax error in eccrypto, so I need to resurrect it.
guibescos
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the wallet adapters used in the proposals app to use the catalog dependencies.
It looks like the solana packages revved some patches but released a number of breaking changes. Unifying on the catalog dependencies both fixes the issues and also makes it easier for me to keep these up to date with the rest of the monorepo moving forward.
Rationale
The proposals app wallet button is currently broken, presumably as a result of #2489 .
How has this been tested?