Replace pyth_sdk_solana::AccKey with solana_program::pubkey::Pubkey #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-bahjati
previously approved these changes
Aug 31, 2022
tompntn
force-pushed
the
solana-pubkey
branch
from
44380f5 to
3db056d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
pyth-sdk-solanain a project that also usessolana-sdk, the fact that our account keys are represented usingpyth_sdk_solana::state::AccKeyinstead ofsolana_sdk::pubkey::Pubkeyis quite unergonomic. Comparing aAccKeyto aPubkeyrequires converting them to be the same type, so code becomes littered with calls to conversion functions.This PR changes
pyth-sdk-solanato usesolana_program::pubkey::Pubkeyfor account keys.Bumping the major version as this is a breaking change.