Liquidity oracle

[anihamde]

No description provided.

[jayantk]

I think you're on the right track here. I think this implementation is going to work in terms of the error of the result.

Couple thoughts on testing:

1. If you break things down into smaller functions, you can test the assumptions on those functions exhaustively to ensure that they satisfy the properties. For example, you can make a function like Price::fraction(x, y) which returns x/y in expo=-9. That function is much easier to test at all of the end ranges and tricky cases. Then you can use this function in affine_combination and depend on its properties.
2. It's probably easier to test affine_combination than the wrapper functions (because the argument signature is simpler). I think here you need to ask what assumptions does this function make about the input Prices and, if those assumptions are satisfied, what guarantees does it make about the result? Can you add tests that validate that those properties are satisfied? For example, I think the current logic is not going to work well if the prices are not representable in expo=-18.

I left a couple of other minor comments throughout.

[jayantk]

i think you're getting very close here

[jayantk]

awesome!